From 5f5340b459ea81938147f5e0c3a2cda63c5b68d1 Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20=E2=80=98Bombe=E2=80=99=20Roden?= Date: Mon, 27 Sep 2021 16:08:29 +0200 Subject: [PATCH] Improve names of startup-related tests Because honestly, what does "new config" even mean? Nobody knows unless they also know the implementation (which ties a boolean value to an annotation named "NewConfig") so stating clearly in which scenarios the tests are running is preferrable. Like, by A LOT. --- src/test/kotlin/net/pterodactylus/sone/main/SonePluginTest.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/kotlin/net/pterodactylus/sone/main/SonePluginTest.kt b/src/test/kotlin/net/pterodactylus/sone/main/SonePluginTest.kt index d1e2cec..a656702 100644 --- a/src/test/kotlin/net/pterodactylus/sone/main/SonePluginTest.kt +++ b/src/test/kotlin/net/pterodactylus/sone/main/SonePluginTest.kt @@ -147,7 +147,7 @@ class SonePluginTest { } @Test - fun `config-not-read event is sent to event bus when new config is true`() { + fun `config-not-read event is sent to event bus when config file is invalid`() { File("sone.properties").deleteAfter { writeText("Invalid") val configNotReadReceived = AtomicBoolean() @@ -160,7 +160,7 @@ class SonePluginTest { } @Test - fun `config-not-read event is not sent to event bus when first start is true`() { + fun `config-not-read event is not sent to event bus when config file does not exist`() { File("sone.properties").delete() val configNotReadReceived = AtomicBoolean() runSonePluginWithRealInjector { @@ -171,7 +171,7 @@ class SonePluginTest { } @Test - fun `config-not-read event is not sent to event bus when new config is false`() { + fun `config-not-read event is not sent to event bus when config file is valid`() { File("sone.properties").deleteAfter { writeText("# comment") val configNotReadReceived = AtomicBoolean() -- 2.7.4