From 85854c510cd14b1999b0caab8849df28cd2b1355 Mon Sep 17 00:00:00 2001 From: =?utf8?q?David=20=E2=80=98Bombe=E2=80=99=20Roden?= Date: Mon, 4 Feb 2013 06:36:08 +0100 Subject: [PATCH] Extract abstract post reply builder class. --- .../sone/data/impl/AbstractPostReplyBuilder.java | 65 ++++++++++++++++++++++ .../sone/data/impl/PostReplyBuilderImpl.java | 15 +---- 2 files changed, 67 insertions(+), 13 deletions(-) create mode 100644 src/main/java/net/pterodactylus/sone/data/impl/AbstractPostReplyBuilder.java diff --git a/src/main/java/net/pterodactylus/sone/data/impl/AbstractPostReplyBuilder.java b/src/main/java/net/pterodactylus/sone/data/impl/AbstractPostReplyBuilder.java new file mode 100644 index 0000000..952a94e --- /dev/null +++ b/src/main/java/net/pterodactylus/sone/data/impl/AbstractPostReplyBuilder.java @@ -0,0 +1,65 @@ +/* + * Sone - AbstractPostReplyBuilder.java - Copyright © 2013 David Roden + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +package net.pterodactylus.sone.data.impl; + +import static com.google.common.base.Preconditions.checkState; + +import org.apache.commons.lang.StringUtils; + +import net.pterodactylus.sone.database.PostReplyBuilder; + +/** + * Abstract {@link PostReplyBuilder} implementation. It stores the state of the + * new post and performs validation, implementations only need to implement + * {@link #build()}. + * + * @author David ‘Bombe’ Roden + */ +public abstract class AbstractPostReplyBuilder extends AbstractReplyBuilder implements PostReplyBuilder { + + /** The ID of the post the created reply refers to. */ + protected String postId; + + /** + * {@inheritDoc} + */ + @Override + public PostReplyBuilder to(String postId) { + this.postId = postId; + return this; + } + + // + // PROTECTED METHODS + // + + /** + * Validates the state of this post reply builder. + * + * @throws IllegalStateException + * if the state is not valid for building a new post reply + */ + protected void validate() throws IllegalStateException { + checkState((randomId && (id == null)) || (!randomId && (id != null)), "either random ID nor custom ID must be set"); + checkState(senderId != null, "sender must not be null"); + checkState((currentTime && (time == 0)) || (!currentTime && (time >= 0)), "either current time or custom time must be set"); + checkState(!StringUtils.isBlank(text), "text must not be empty"); + checkState(postId != null, "post must not be null"); + } + +} diff --git a/src/main/java/net/pterodactylus/sone/data/impl/PostReplyBuilderImpl.java b/src/main/java/net/pterodactylus/sone/data/impl/PostReplyBuilderImpl.java index da18f96..dac84ad 100644 --- a/src/main/java/net/pterodactylus/sone/data/impl/PostReplyBuilderImpl.java +++ b/src/main/java/net/pterodactylus/sone/data/impl/PostReplyBuilderImpl.java @@ -34,7 +34,7 @@ import org.apache.commons.lang.StringUtils; * * @author David ‘Bombe’ Roden */ -public class PostReplyBuilderImpl extends AbstractReplyBuilder implements PostReplyBuilder { +public class PostReplyBuilderImpl extends AbstractPostReplyBuilder { /** The Sone provider. */ private final SoneProvider soneProvider; @@ -42,9 +42,6 @@ public class PostReplyBuilderImpl extends AbstractReplyBuilder /** The post provider. */ private final PostProvider postProvider; - /** The ID of the post the created reply refers to. */ - private String postId; - /** * Creates a new post reply builder. * @@ -62,15 +59,6 @@ public class PostReplyBuilderImpl extends AbstractReplyBuilder * {@inheritDoc} */ @Override - public PostReplyBuilder to(String postId) { - this.postId = postId; - return this; - } - - /** - * {@inheritDoc} - */ - @Override public PostReply build() { checkState((randomId && (id == null)) || (!randomId && (id != null)), "either random ID nor custom ID must be set"); checkState(senderId != null, "sender must not be null"); @@ -81,4 +69,5 @@ public class PostReplyBuilderImpl extends AbstractReplyBuilder /* create new post reply. */ return new PostReplyImpl(soneProvider, postProvider, randomId ? UUID.randomUUID().toString() : id, senderId, currentTime ? System.currentTimeMillis() : time, text, postId); } + } -- 2.7.4