throw new InvalidXml();
}
- Optional<SimpleXML> soneXml = parseXml(originalSone, document);
- if (!soneXml.isPresent()) {
- logger.log(Level.WARNING, String.format("XML for Sone %s can not be parsed!", originalSone.getId()));
- throw new InvalidXml();
- }
-
- Optional<Client> parsedClient = parseClient(originalSone, soneXml.get());
+ SimpleXML soneXml = SimpleXML.fromDocument(document);
+ Optional<Client> parsedClient = parseClient(originalSone, soneXml);
Sone sone = new DefaultSone(database, originalSone.getId(), originalSone.isLocal(), parsedClient.or(originalSone.getClient()));
- Optional<Integer> protocolVersion = parseProtocolVersion(soneXml.get());
- if (protocolVersion.isPresent()) {
- if (protocolVersion.get() < 0) {
- logger.log(Level.WARNING, String.format("Invalid protocol version: %d! Not parsing Sone.", protocolVersion.get()));
- throw new InvalidProtocolVersion();
- }
- if (protocolVersion.get() > MAX_PROTOCOL_VERSION) {
- logger.log(Level.WARNING, String.format("Unknown protocol version: %d! Not parsing Sone.", protocolVersion.get()));
- throw new InvalidProtocolVersion();
- }
- }
+ verifyProtocolVersion(soneXml);
- String soneTime = soneXml.get().getValue("time", null);
- if (soneTime == null) {
- /* TODO - mark Sone as bad. */
- logger.log(Level.WARNING, String.format("Downloaded time for Sone %s was null!", sone));
- throw new MalformedXml();
- }
- try {
- sone.setTime(Long.parseLong(soneTime));
- } catch (NumberFormatException nfe1) {
- /* TODO - mark Sone as bad. */
- logger.log(Level.WARNING, String.format("Downloaded Sone %s with invalid time: %s", sone, soneTime));
- throw new MalformedXml();
- }
+ parseTime(soneXml, sone);
- SimpleXML profileXml = soneXml.get().getNode("profile");
+ SimpleXML profileXml = soneXml.getNode("profile");
if (profileXml == null) {
/* TODO - mark Sone as bad. */
logger.log(Level.WARNING, String.format("Downloaded Sone %s has no profile!", sone));
profile.setField(profile.addField(fieldName), fieldValue);
} catch (IllegalArgumentException iae1) {
logger.log(Level.WARNING, String.format("Duplicate field: %s", fieldName), iae1);
- return null;
+ throw new DuplicateField();
}
}
}
/* parse posts. */
- SimpleXML postsXml = soneXml.get().getNode("posts");
+ SimpleXML postsXml = soneXml.getNode("posts");
Set<Post> posts = new HashSet<Post>();
if (postsXml == null) {
/* TODO - mark Sone as bad. */
if ((postId == null) || (postTime == null) || (postText == null)) {
/* TODO - mark Sone as bad. */
logger.log(Level.WARNING, String.format("Downloaded post for Sone %s with missing data! ID: %s, Time: %s, Text: %s", sone, postId, postTime, postText));
- return null;
+ throw new MalformedXml();
}
try {
PostBuilder postBuilder = sone.newPostBuilder();
} catch (NumberFormatException nfe1) {
/* TODO - mark Sone as bad. */
logger.log(Level.WARNING, String.format("Downloaded post for Sone %s with invalid time: %s", sone, postTime));
- return null;
+ throw new MalformedTime();
}
}
}
/* parse replies. */
- SimpleXML repliesXml = soneXml.get().getNode("replies");
+ SimpleXML repliesXml = soneXml.getNode("replies");
Set<PostReply> replies = new HashSet<PostReply>();
if (repliesXml == null) {
/* TODO - mark Sone as bad. */
if ((replyId == null) || (replyPostId == null) || (replyTime == null) || (replyText == null)) {
/* TODO - mark Sone as bad. */
logger.log(Level.WARNING, String.format("Downloaded reply for Sone %s with missing data! ID: %s, Post: %s, Time: %s, Text: %s", sone, replyId, replyPostId, replyTime, replyText));
- return null;
+ throw new MalformedXml();
}
try {
/* TODO - parse time correctly. */
} catch (NumberFormatException nfe1) {
/* TODO - mark Sone as bad. */
logger.log(Level.WARNING, String.format("Downloaded reply for Sone %s with invalid time: %s", sone, replyTime));
- return null;
+ throw new MalformedTime();
}
}
}
/* parse liked post IDs. */
- SimpleXML likePostIdsXml = soneXml.get().getNode("post-likes");
+ SimpleXML likePostIdsXml = soneXml.getNode("post-likes");
Set<String> likedPostIds = new HashSet<String>();
if (likePostIdsXml == null) {
/* TODO - mark Sone as bad. */
}
/* parse liked reply IDs. */
- SimpleXML likeReplyIdsXml = soneXml.get().getNode("reply-likes");
+ SimpleXML likeReplyIdsXml = soneXml.getNode("reply-likes");
Set<String> likedReplyIds = new HashSet<String>();
if (likeReplyIdsXml == null) {
/* TODO - mark Sone as bad. */
}
/* parse albums. */
- SimpleXML albumsXml = soneXml.get().getNode("albums");
+ SimpleXML albumsXml = soneXml.getNode("albums");
Map<String, Album> albums = Maps.newHashMap();
if (albumsXml != null) {
for (SimpleXML albumXml : albumsXml.getNodes("album")) {
String albumImageId = albumXml.getValue("album-image", null);
if ((id == null) || (title == null) || (description == null)) {
logger.log(Level.WARNING, String.format("Downloaded Sone %s contains invalid album!", sone));
- return null;
+ throw new MalformedXml();
}
Album parent = sone.getRootAlbum();
if (parentId != null) {
parent = albums.get(parentId);
if (parent == null) {
logger.log(Level.WARNING, String.format("Downloaded Sone %s has album with invalid parent!", sone));
- return null;
+ throw new InvalidParentAlbum();
}
}
Album album = parent.newAlbumBuilder().withId(id).build().modify().setTitle(title).setDescription(description).update();
String imageHeightString = imageXml.getValue("height", null);
if ((imageId == null) || (imageCreationTimeString == null) || (imageKey == null) || (imageTitle == null) || (imageWidthString == null) || (imageHeightString == null)) {
logger.log(Level.WARNING, String.format("Downloaded Sone %s contains invalid images!", sone));
- return null;
+ throw new MalformedXml();
}
long creationTime = Numbers.safeParseLong(imageCreationTimeString, 0L);
int imageWidth = Numbers.safeParseInteger(imageWidthString, 0);
int imageHeight = Numbers.safeParseInteger(imageHeightString, 0);
if ((imageWidth < 1) || (imageHeight < 1)) {
logger.log(Level.WARNING, String.format("Downloaded Sone %s contains image %s with invalid dimensions (%s, %s)!", sone, imageId, imageWidthString, imageHeightString));
- return null;
+ throw new MalformedDimension();
}
Image image = album.newImageBuilder().withId(imageId).at(imageKey).created(creationTime).sized(imageWidth, imageHeight).build(Optional.<ImageCreated>absent());
image = image.modify().setTitle(imageTitle).setDescription(imageDescription).update();
return sone;
}
+ private void parseTime(SimpleXML soneXml, Sone sone) {
+ String soneTime = soneXml.getValue("time", null);
+ if (soneTime == null) {
+ /* TODO - mark Sone as bad. */
+ logger.log(Level.WARNING, String.format("Downloaded time for Sone %s was null!", sone));
+ throw new MalformedXml();
+ }
+ try {
+ sone.setTime(Long.parseLong(soneTime));
+ } catch (NumberFormatException nfe1) {
+ /* TODO - mark Sone as bad. */
+ logger.log(Level.WARNING, String.format("Downloaded Sone %s with invalid time: %s", sone, soneTime));
+ throw new MalformedTime();
+ }
+ }
+
+ private void verifyProtocolVersion(SimpleXML soneXml) {
+ Optional<Integer> protocolVersion = parseProtocolVersion(soneXml);
+ if (protocolVersion.isPresent()) {
+ if (protocolVersion.get() < 0) {
+ logger.log(Level.WARNING, String.format("Invalid protocol version: %d! Not parsing Sone.", protocolVersion.get()));
+ throw new InvalidProtocolVersion();
+ }
+ if (protocolVersion.get() > MAX_PROTOCOL_VERSION) {
+ logger.log(Level.WARNING, String.format("Unknown protocol version: %d! Not parsing Sone.", protocolVersion.get()));
+ throw new SoneTooNew();
+ }
+ }
+ }
+
private Optional<Integer> parseProtocolVersion(SimpleXML soneXml) {
String soneProtocolVersion = soneXml.getValue("protocol-version", null);
if (soneProtocolVersion == null) {
return fromNullable(Ints.tryParse(soneProtocolVersion));
}
- private Optional<SimpleXML> parseXml(Sone originalSone, Document document) {
- try {
- return fromNullable(SimpleXML.fromDocument(document));
- } catch (NullPointerException npe1) {
- /* for some reason, invalid XML can cause NPEs. */
- return absent();
- }
- }
-
private Optional<Client> parseClient(Sone sone, SimpleXML soneXml) {
SimpleXML clientXml = soneXml.getNode("client");
if (clientXml == null) {
}
+ public static class SoneTooNew extends RuntimeException {
+
+ }
+
public static class MalformedXml extends RuntimeException {
}
+
+ public static class DuplicateField extends RuntimeException {
+
+ }
+
+ public static class MalformedTime extends RuntimeException {
+
+ }
+
+ public static class InvalidParentAlbum extends RuntimeException {
+
+ }
+
+ public static class MalformedDimension extends RuntimeException {
+
+ }
+
}
projects / Sone.git / blobdiff