If no current Sone exists, return an error.

[Sone.git] / src / main / java / net / pterodactylus / sone / web / EditProfileFieldPage.java

diff --git a/src/main/java/net/pterodactylus/sone/web/EditProfileFieldPage.java b/src/main/java/net/pterodactylus/sone/web/EditProfileFieldPage.java
index 2b72a81..a71abdc 100644 (file)
--- a/src/main/java/net/pterodactylus/sone/web/EditProfileFieldPage.java
+++ b/src/main/java/net/pterodactylus/sone/web/EditProfileFieldPage.java
@@ -1,5 +1,5 @@
 /*
- * Sone - EditProfileFieldPage.java - Copyright © 2011 David Roden
+ * Sone - EditProfileFieldPage.java - Copyright © 2011–2013 David Roden
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -18,11 +18,14 @@
 package net.pterodactylus.sone.web;
 
 import net.pterodactylus.sone.data.Profile;
+import net.pterodactylus.sone.data.Profile.Field;
 import net.pterodactylus.sone.data.Sone;
-import net.pterodactylus.sone.web.page.Page.Request.Method;
-import net.pterodactylus.util.number.Numbers;
-import net.pterodactylus.util.template.DataProvider;
+import net.pterodactylus.sone.web.page.FreenetRequest;
 import net.pterodactylus.util.template.Template;
+import net.pterodactylus.util.template.TemplateContext;
+import net.pterodactylus.util.web.Method;
+
+import com.google.common.base.Optional;
 
 /**
  * Page that lets the user edit the name of a profile field.
@@ -47,25 +50,17 @@ public class EditProfileFieldPage extends SoneTemplatePage {
        // SONETEMPLATEPAGE METHODS
        //
 
-       /**
-        * {@inheritDoc}
-        */
        @Override
-       protected void processTemplate(Request request, DataProvider dataProvider) throws RedirectException {
-               super.processTemplate(request, dataProvider);
+       protected void processTemplate(FreenetRequest request, TemplateContext templateContext) throws RedirectException {
+               super.processTemplate(request, templateContext);
                Sone currentSone = getCurrentSone(request.getToadletContext());
                Profile profile = currentSone.getProfile();
 
                /* get parameters from request. */
-               int fieldIndex = Numbers.safeParseInteger(request.getHttpRequest().getParam("field"), -1);
-               if (fieldIndex >= currentSone.getProfile().getFieldNames().size()) {
-                       fieldIndex = -1;
-               }
-               String fieldName = null;
-               String fieldValue = null;
-               if (fieldIndex > -1) {
-                       fieldName = profile.getFieldNames().get(fieldIndex);
-                       fieldValue = profile.getField(fieldName);
+               String fieldId = request.getHttpRequest().getParam("field");
+               Optional<Field> field = profile.getFieldById(fieldId);
+               if (!field.isPresent()) {
+                       throw new RedirectException("invalid.html");
                }
 
                /* process the POST request. */
@@ -73,24 +68,23 @@ public class EditProfileFieldPage extends SoneTemplatePage {
                        if (request.getHttpRequest().getPartAsStringFailsafe("cancel", 4).equals("true")) {
                                throw new RedirectException("editProfile.html#profile-fields");
                        }
-                       fieldIndex = Numbers.safeParseInteger(request.getHttpRequest().getPartAsStringFailsafe("field", 11), -1);
-                       String name = request.getHttpRequest().getPartAsStringFailsafe("name", 256);
-                       if (fieldIndex == -1) {
+                       fieldId = request.getHttpRequest().getPartAsStringFailsafe("field", 36);
+                       field = profile.getFieldById(fieldId);
+                       if (!field.isPresent()) {
                                throw new RedirectException("invalid.html");
                        }
-                       int existingFieldIndex = profile.getFieldNames().indexOf(name);
-                       if ((existingFieldIndex == -1) || (existingFieldIndex == fieldIndex)) {
-                               profile.setFieldName(fieldIndex, name);
+                       String name = request.getHttpRequest().getPartAsStringFailsafe("name", 256);
+                       Optional<Field> existingField = profile.getFieldByName(name);
+                       if (!existingField.isPresent() || existingField.equals(field)) {
+                               profile.renameField(field.get(), name);
                                currentSone.setProfile(profile);
                                throw new RedirectException("editProfile.html#profile-fields");
                        }
-                       dataProvider.set("duplicateFieldName", true);
+                       templateContext.set("duplicateFieldName", true);
                }
 
                /* store current values in template. */
-               dataProvider.set("fieldIndex", fieldIndex);
-               dataProvider.set("fieldName", fieldName);
-               dataProvider.set("fieldValue", fieldValue);
+               templateContext.set("field", field.get());
        }
 
 }