Don’t crash on parsing incorrect XML.

[Sone.git] / src / main / java / net / pterodactylus / sone / core / SoneDownloader.java

diff --git a/src/main/java/net/pterodactylus/sone/core/SoneDownloader.java b/src/main/java/net/pterodactylus/sone/core/SoneDownloader.java
index 091efca..a36c17a 100644 (file)
--- a/src/main/java/net/pterodactylus/sone/core/SoneDownloader.java
+++ b/src/main/java/net/pterodactylus/sone/core/SoneDownloader.java
@@ -24,6 +24,9 @@ import java.util.Set;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
+import net.pterodactylus.sone.data.Post;
+import net.pterodactylus.sone.data.Profile;
+import net.pterodactylus.sone.data.Reply;
 import net.pterodactylus.sone.data.Sone;
 import net.pterodactylus.util.io.Closer;
 import net.pterodactylus.util.logging.Logging;
@@ -46,6 +49,9 @@ public class SoneDownloader extends AbstractService {
        /** The logger. */
        private static final Logger logger = Logging.getLogger(SoneDownloader.class);
 
+       /** The core. */
+       private final Core core;
+
        /** The Freenet interface. */
        private final FreenetInterface freenetInterface;
 
@@ -55,11 +61,14 @@ public class SoneDownloader extends AbstractService {
        /**
         * Creates a new Sone downloader.
         *
+        * @param core
+        *            The core
         * @param freenetInterface
         *            The Freenet interface
         */
-       public SoneDownloader(FreenetInterface freenetInterface) {
+       public SoneDownloader(Core core, FreenetInterface freenetInterface) {
                super("Sone Downloader");
+               this.core = core;
                this.freenetInterface = freenetInterface;
        }
 
@@ -128,7 +137,14 @@ public class SoneDownloader extends AbstractService {
                        xmlBucket = fetchResult.asBucket();
                        xmlInputStream = xmlBucket.getInputStream();
                        Document document = XML.transformToDocument(xmlInputStream);
-                       SimpleXML soneXml = SimpleXML.fromDocument(document);
+                       SimpleXML soneXml;
+                       try {
+                               soneXml = SimpleXML.fromDocument(document);
+                       } catch (NullPointerException npe1) {
+                               /* for some reason, invalid XML can cause NPEs. */
+                               logger.log(Level.WARNING, "XML for Sone " + sone + " can not be parsed!", npe1);
+                               return;
+                       }
 
                        /* check ID. */
                        String soneId = soneXml.getValue("id", null);
@@ -153,7 +169,71 @@ public class SoneDownloader extends AbstractService {
                        }
 
                        /* parse profile. */
+                       String profileFirstName = profileXml.getValue("first-name", null);
+                       String profileMiddleName = profileXml.getValue("middle-name", null);
+                       String profileLastName = profileXml.getValue("last-name", null);
+                       Profile profile = new Profile().setFirstName(profileFirstName).setMiddleName(profileMiddleName).setLastName(profileLastName);
+
+                       /* parse posts. */
+                       SimpleXML postsXml = soneXml.getNode("posts");
+                       if (postsXml == null) {
+                               /* TODO - mark Sone as bad. */
+                               logger.log(Level.WARNING, "Downloaded Sone %s has no posts!", new Object[] { sone });
+                               return;
+                       }
+
+                       Set<Post> posts = new HashSet<Post>();
+                       for (SimpleXML postXml : postsXml.getNodes("post")) {
+                               String postId = postXml.getValue("id", null);
+                               String postTime = postXml.getValue("time", null);
+                               String postText = postXml.getValue("text", null);
+                               if ((postId == null) || (postTime == null) || (postText == null)) {
+                                       /* TODO - mark Sone as bad. */
+                                       logger.log(Level.WARNING, "Downloaded post for Sone %s with missing data! ID: %s, Time: %s, Text: %s", new Object[] { sone, postId, postTime, postText });
+                                       return;
+                               }
+                               try {
+                                       posts.add(core.getPost(postId).setSone(sone).setTime(Long.parseLong(postTime)).setText(postText));
+                               } catch (NumberFormatException nfe1) {
+                                       /* TODO - mark Sone as bad. */
+                                       logger.log(Level.WARNING, "Downloaded post for Sone %s with invalid time: %s", new Object[] { sone, postTime });
+                                       return;
+                               }
+                       }
 
+                       /* parse replies. */
+                       SimpleXML repliesXml = soneXml.getNode("replies");
+                       if (repliesXml == null) {
+                               /* TODO - mark Sone as bad. */
+                               logger.log(Level.WARNING, "Downloaded Sone %s has no replies!", new Object[] { sone });
+                               return;
+                       }
+
+                       Set<Reply> replies = new HashSet<Reply>();
+                       for (SimpleXML replyXml : repliesXml.getNodes("reply")) {
+                               String replyId = replyXml.getValue("id", null);
+                               String replyPostId = replyXml.getValue("post-id", null);
+                               String replyTime = replyXml.getValue("time", null);
+                               String replyText = replyXml.getValue("text", null);
+                               if ((replyId == null) || (replyPostId == null) || (replyTime == null) || (replyText == null)) {
+                                       /* TODO - mark Sone as bad. */
+                                       logger.log(Level.WARNING, "Downloaded reply for Sone %s with missing data! ID: %s, Post: %s, Time: %s, Text: %s", new Object[] { sone, replyId, replyPostId, replyTime, replyText });
+                                       return;
+                               }
+                               try {
+                                       replies.add(core.getReply(replyId).setSone(sone).setPost(core.getPost(replyPostId)).setTime(Long.parseLong(replyTime)).setText(replyText));
+                               } catch (NumberFormatException nfe1) {
+                                       /* TODO - mark Sone as bad. */
+                                       logger.log(Level.WARNING, "Downloaded reply for Sone %s with invalid time: %s", new Object[] { sone, replyTime });
+                                       return;
+                               }
+                       }
+
+                       /* okay, apparently everything was parsed correctly. Now import. */
+                       /* atomic setter operation on the Sone. */
+                       synchronized (sone) {
+                               sone.setProfile(profile);
+                       }
                } catch (IOException ioe1) {
                        logger.log(Level.WARNING, "Could not read XML file from " + sone + "!", ioe1);
                } finally {