🔀 Merge “release/v81” into “master”
[Sone.git] / src / test / java / net / pterodactylus / sone / core / WebOfTrustUpdaterTest.java
index ff646b0..d7d9b48 100644 (file)
@@ -6,56 +6,40 @@ import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.not;
-import static org.mockito.Matchers.eq;
-import static org.mockito.Mockito.doAnswer;
-import static org.mockito.Mockito.doThrow;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.*;
 
 import java.util.concurrent.CountDownLatch;
-import java.util.concurrent.atomic.AtomicInteger;
-
-import net.pterodactylus.sone.core.WebOfTrustUpdater.AddContextJob;
-import net.pterodactylus.sone.core.WebOfTrustUpdater.RemoveContextJob;
-import net.pterodactylus.sone.core.WebOfTrustUpdater.SetPropertyJob;
-import net.pterodactylus.sone.core.WebOfTrustUpdater.SetTrustJob;
-import net.pterodactylus.sone.core.WebOfTrustUpdater.WebOfTrustContextUpdateJob;
-import net.pterodactylus.sone.core.WebOfTrustUpdater.WebOfTrustUpdateJob;
+
+import net.pterodactylus.sone.core.WebOfTrustUpdaterImpl.AddContextJob;
+import net.pterodactylus.sone.core.WebOfTrustUpdaterImpl.RemoveContextJob;
+import net.pterodactylus.sone.core.WebOfTrustUpdaterImpl.SetPropertyJob;
+import net.pterodactylus.sone.core.WebOfTrustUpdaterImpl.WebOfTrustContextUpdateJob;
+import net.pterodactylus.sone.core.WebOfTrustUpdaterImpl.WebOfTrustUpdateJob;
 import net.pterodactylus.sone.freenet.plugin.PluginException;
 import net.pterodactylus.sone.freenet.wot.Identity;
 import net.pterodactylus.sone.freenet.wot.OwnIdentity;
-import net.pterodactylus.sone.freenet.wot.Trust;
 import net.pterodactylus.sone.freenet.wot.WebOfTrustConnector;
-import net.pterodactylus.sone.freenet.wot.WebOfTrustException;
 
 import org.junit.Test;
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
 
 /**
- * Unit test for {@link WebOfTrustUpdater} and its subclasses.
- *
- * @author <a href="mailto:bombe@pterodactylus.net">David ‘Bombe’ Roden</a>
+ * Unit test for {@link WebOfTrustUpdaterImpl} and its subclasses.
  */
 public class WebOfTrustUpdaterTest {
 
        private static final String CONTEXT = "test-context";
-       private static final Integer SCORE = 50;
-       private static final Integer OTHER_SCORE = 25;
-       private static final String TRUST_COMMENT = "set in a test";
        private static final String PROPERTY_NAME = "test-property";
        private final WebOfTrustConnector webOfTrustConnector = mock(WebOfTrustConnector.class);
-       private final WebOfTrustUpdater webOfTrustUpdater = new WebOfTrustUpdater(webOfTrustConnector);
+       private final WebOfTrustUpdaterImpl webOfTrustUpdater = new WebOfTrustUpdaterImpl(webOfTrustConnector);
        private final OwnIdentity ownIdentity = when(mock(OwnIdentity.class).getId()).thenReturn("own-identity-id").getMock();
        private final WebOfTrustUpdateJob successfulWebOfTrustUpdateJob = createWebOfTrustUpdateJob(true);
        private final WebOfTrustUpdateJob failingWebOfTrustUpdateJob = createWebOfTrustUpdateJob(false);
        private final WebOfTrustContextUpdateJob contextUpdateJob = webOfTrustUpdater.new WebOfTrustContextUpdateJob(ownIdentity, CONTEXT);
        private final AddContextJob addContextJob = webOfTrustUpdater.new AddContextJob(ownIdentity, CONTEXT);
        private final RemoveContextJob removeContextJob = webOfTrustUpdater.new RemoveContextJob(ownIdentity, CONTEXT);
-       private final Identity trustee = when(mock(Identity.class).getId()).thenReturn("trustee-id").getMock();
 
        private WebOfTrustUpdateJob createWebOfTrustUpdateJob(final boolean success) {
                return webOfTrustUpdater.new WebOfTrustUpdateJob() {
@@ -239,81 +223,6 @@ public class WebOfTrustUpdaterTest {
        }
 
        @Test
-       public void setTrustJobSetsTrust() throws PluginException {
-               SetTrustJob setTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               setTrustJob.run();
-               verify(webOfTrustConnector).setTrust(eq(ownIdentity), eq(trustee), eq(SCORE), eq(TRUST_COMMENT));
-               verify(trustee).setTrust(eq(ownIdentity), eq(new Trust(SCORE, null, 0)));
-               assertThat(setTrustJob.waitForCompletion(), is(true));
-       }
-
-       @Test
-       public void settingNullTrustRemovesTrust() throws WebOfTrustException {
-               SetTrustJob setTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, null, TRUST_COMMENT);
-               setTrustJob.run();
-               verify(webOfTrustConnector).removeTrust(eq(ownIdentity), eq(trustee));
-               verify(trustee).removeTrust(eq(ownIdentity));
-               assertThat(setTrustJob.waitForCompletion(), is(true));
-       }
-
-       @Test
-       public void exceptionWhileSettingTrustIsCaught() throws PluginException {
-               doThrow(PluginException.class).when(webOfTrustConnector).setTrust(eq(ownIdentity), eq(trustee), eq(SCORE), eq(TRUST_COMMENT));
-               SetTrustJob setTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               setTrustJob.run();
-               verify(webOfTrustConnector).setTrust(eq(ownIdentity), eq(trustee), eq(SCORE), eq(TRUST_COMMENT));
-               verify(trustee, never()).setTrust(eq(ownIdentity), eq(new Trust(SCORE, null, 0)));
-               assertThat(setTrustJob.waitForCompletion(), is(false));
-       }
-
-       @Test
-       public void setTrustJobsWithDifferentClassesAreNotEqual() {
-               SetTrustJob firstSetTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               SetTrustJob secondSetTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT) {
-               };
-               assertThat(firstSetTrustJob, not(is(secondSetTrustJob)));
-               assertThat(secondSetTrustJob, not(is(firstSetTrustJob)));
-       }
-
-       @Test
-       public void setTrustJobsWithDifferentTrustersAreNotEqual() {
-               SetTrustJob firstSetTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               SetTrustJob secondSetTrustJob = webOfTrustUpdater.new SetTrustJob(mock(OwnIdentity.class), trustee, SCORE, TRUST_COMMENT);
-               assertThat(firstSetTrustJob, not(is(secondSetTrustJob)));
-               assertThat(secondSetTrustJob, not(is(firstSetTrustJob)));
-       }
-
-       @Test
-       public void setTrustJobsWithDifferentTrusteesAreNotEqual() {
-               SetTrustJob firstSetTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               SetTrustJob secondSetTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, mock(Identity.class), SCORE, TRUST_COMMENT);
-               assertThat(firstSetTrustJob, not(is(secondSetTrustJob)));
-               assertThat(secondSetTrustJob, not(is(firstSetTrustJob)));
-       }
-
-       @Test
-       public void setTrustJobsWithDifferentScoreAreEqual() {
-               SetTrustJob firstSetTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               SetTrustJob secondSetTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, OTHER_SCORE, TRUST_COMMENT);
-               assertThat(firstSetTrustJob, is(secondSetTrustJob));
-               assertThat(secondSetTrustJob, is(firstSetTrustJob));
-               assertThat(firstSetTrustJob.hashCode(), is(secondSetTrustJob.hashCode()));
-       }
-
-       @Test
-       public void setTrustJobDoesNotEqualNull() {
-               SetTrustJob setTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               assertThat(setTrustJob, not(is((Object) null)));
-       }
-
-       @Test
-       public void toStringOfSetTrustJobContainsIdsOfTrusterAndTrustee() {
-               SetTrustJob setTrustJob = webOfTrustUpdater.new SetTrustJob(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               assertThat(setTrustJob.toString(), containsString(ownIdentity.getId()));
-               assertThat(setTrustJob.toString(), containsString(trustee.getId()));
-       }
-
-       @Test
        public void webOfTrustUpdaterStopsWhenItShould() {
                webOfTrustUpdater.stop();
                webOfTrustUpdater.serviceRun();
@@ -365,30 +274,6 @@ public class WebOfTrustUpdaterTest {
        }
 
        @Test
-       public void multipleCallsToAddContextAreCollapsed() throws InterruptedException, PluginException {
-               final AtomicInteger errorCount = new AtomicInteger();
-               final CountDownLatch addContextsFinished = new CountDownLatch(2);
-               for (int i = 1; i <= 2; i++) {
-                       /* this is so fucking volatile. */
-                       if (i > 1) {
-                               sleep(200);
-                       }
-                       new Thread(new Runnable() {
-                               public void run() {
-                                       if (!webOfTrustUpdater.addContextWait(ownIdentity, CONTEXT)) {
-                                               errorCount.incrementAndGet();
-                                       }
-                                       addContextsFinished.countDown();
-                               }
-                       }).start();
-               }
-               webOfTrustUpdater.start();
-               assertThat(addContextsFinished.await(1, SECONDS), is(true));
-               verify(ownIdentity).addContext(eq(CONTEXT));
-               assertThat(errorCount.get(), is(0));
-       }
-
-       @Test
        public void removeContextRemovesAContext() throws InterruptedException, PluginException {
                webOfTrustUpdater.start();
                final CountDownLatch removeContextTrigger = new CountDownLatch(1);
@@ -432,48 +317,4 @@ public class WebOfTrustUpdaterTest {
                verify(ownIdentity).removeContext(eq(CONTEXT));
        }
 
-       @Test
-       public void setTrustSetsTrust() throws InterruptedException, PluginException {
-               final CountDownLatch trustSetTrigger =new CountDownLatch(1);
-               doAnswer(new Answer<Void>() {
-                       @Override
-                       public Void answer(InvocationOnMock invocation) throws Throwable {
-                               trustSetTrigger.countDown();
-                               return null;
-                       }
-               }).when(trustee).setTrust(eq(ownIdentity), eq(new Trust(SCORE, null, 0)));
-               webOfTrustUpdater.start();
-               webOfTrustUpdater.setTrust(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-               assertThat(trustSetTrigger.await(1, SECONDS), is(true));
-               verify(trustee).setTrust(eq(ownIdentity), eq(new Trust(SCORE, null, 0)));
-               verify(webOfTrustConnector).setTrust(eq(ownIdentity), eq(trustee), eq(SCORE), eq(TRUST_COMMENT));
-       }
-
-       @Test
-       public void setTrustRequestsAreCoalesced() throws InterruptedException, PluginException {
-               final CountDownLatch trustSetTrigger = new CountDownLatch(1);
-               doAnswer(new Answer<Void>() {
-                       @Override
-                       public Void answer(InvocationOnMock invocation) throws Throwable {
-                               trustSetTrigger.countDown();
-                               return null;
-                       }
-               }).when(trustee).setTrust(eq(ownIdentity), eq(new Trust(SCORE, null, 0)));
-               for (int i = 1; i <= 2; i++) {
-                       /* this is so fucking volatile. */
-                       if (i > 1) {
-                               sleep(200);
-                       }
-                       new Thread(new Runnable() {
-                               public void run() {
-                                       webOfTrustUpdater.setTrust(ownIdentity, trustee, SCORE, TRUST_COMMENT);
-                               }
-                       }).start();
-               }
-               webOfTrustUpdater.start();
-               assertThat(trustSetTrigger.await(1, SECONDS), is(true));
-               verify(trustee).setTrust(eq(ownIdentity), eq(new Trust(SCORE, null, 0)));
-               verify(webOfTrustConnector).setTrust(eq(ownIdentity), eq(trustee), eq(SCORE), eq(TRUST_COMMENT));
-       }
-
 }