Move assertions to base class

[Sone.git] / src / test / kotlin / net / pterodactylus / sone / web / ajax / BookmarkAjaxPageTest.kt

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/ajax/BookmarkAjaxPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/ajax/BookmarkAjaxPageTest.kt
index 1d26c71..17c334e 100644 (file)
--- a/src/test/kotlin/net/pterodactylus/sone/web/ajax/BookmarkAjaxPageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/ajax/BookmarkAjaxPageTest.kt
@@ -11,35 +11,23 @@ import org.mockito.Mockito.verify
 /**
  * Unit test for [BookmarkAjaxPage].
  */
-class BookmarkAjaxPageTest : JsonPageTest(::BookmarkAjaxPage) {
-
-       @Test
-       fun `page returns correct path`() {
-               assertThat(page.path, equalTo("bookmark.ajax"))
-       }
-
-       @Test
-       fun `page does not require login`() {
-           assertThat(page.requiresLogin(), equalTo(false))
-       }
+class BookmarkAjaxPageTest : JsonPageTest("bookmark.ajax", requiresLogin = false, pageSupplier = ::BookmarkAjaxPage) {
 
        @Test
        fun `missing post ID results in invalid id response`() {
-               assertThat(json.isSuccess, equalTo(false))
-               assertThat((json as JsonErrorReturnObject).error, equalTo("invalid-post-id"))
+               assertThatJsonFailed("invalid-post-id")
        }
 
        @Test
        fun `empty post ID results in invalid id response`() {
                addRequestParameter("post", "")
-               assertThat(json.isSuccess, equalTo(false))
-               assertThat((json as JsonErrorReturnObject).error, equalTo("invalid-post-id"))
+               assertThatJsonFailed("invalid-post-id")
        }
 
        @Test
        fun `invalid post ID results in success but does not bookmark anything`() {
                addRequestParameter("post", "missing")
-               assertThat(json.isSuccess, equalTo(true))
+               assertThatJsonIsSuccessful()
                verify(core, never()).bookmarkPost(any<Post>())
        }
 
@@ -47,7 +35,7 @@ class BookmarkAjaxPageTest : JsonPageTest(::BookmarkAjaxPage) {
        fun `valid post ID results in success and bookmarks the post`() {
                addRequestParameter("post", "valid-post-id")
                val post = addNewPost("valid-post-id", "1", 2)
-               assertThat(json.isSuccess, equalTo(true))
+               assertThatJsonIsSuccessful()
                verify(core).bookmarkPost(post)
        }