Move recurring tests for ajax pages to test base class

[Sone.git] / src / test / kotlin / net / pterodactylus / sone / web / ajax / JsonPageTest.kt

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt
index b0a67d4..5d43a1e 100644 (file)
--- a/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/ajax/JsonPageTest.kt
@@ -20,7 +20,10 @@ import net.pterodactylus.sone.web.WebInterface
 import net.pterodactylus.sone.web.page.FreenetRequest
 import net.pterodactylus.util.notify.Notification
 import net.pterodactylus.util.web.Method.GET
+import org.hamcrest.MatcherAssert.assertThat
+import org.hamcrest.Matchers.equalTo
 import org.junit.Before
+import org.junit.Test
 import org.mockito.ArgumentMatchers.anyBoolean
 import org.mockito.ArgumentMatchers.anyInt
 import org.mockito.ArgumentMatchers.anyString
@@ -32,7 +35,11 @@ import javax.naming.SizeLimitExceededException
 /**
  * Base class for tests for any [JsonPage] implementations.
  */
-open class JsonPageTest(pageSupplier: (WebInterface) -> JsonPage = { _ -> mock<JsonPage>() }) {
+abstract class JsonPageTest(
+               private val expectedPath: String,
+               private val requiresLogin: Boolean = true,
+               private val needsFormPassword: Boolean = true,
+               pageSupplier: (WebInterface) -> JsonPage = { _ -> mock<JsonPage>() }) {
 
        protected val webInterface = mock<WebInterface>()
        protected val core = mock<Core>()
@@ -50,6 +57,7 @@ open class JsonPageTest(pageSupplier: (WebInterface) -> JsonPage = { _ -> mock<J
        private val requestParts = mutableMapOf<String, String>()
        private val localSones = mutableMapOf<String, Sone>()
        private val remoteSones = mutableMapOf<String, Sone>()
+       private val posts = mutableMapOf<String, Post>()
        private val newPosts = mutableMapOf<String, Post>()
        private val newReplies = mutableMapOf<String, PostReply>()
        private val linkedElements = mutableMapOf<String, LinkedElement>()
@@ -69,7 +77,8 @@ open class JsonPageTest(pageSupplier: (WebInterface) -> JsonPage = { _ -> mock<J
        @Before
        fun setupCore() {
                whenever(core.getSone(anyString())).thenAnswer { (localSones + remoteSones)[it.getArgument(0)].asOptional() }
-               whenever(core.getPost(anyString())).thenAnswer { newPosts[it[0]].asOptional() }
+               whenever(core.getLocalSone(anyString())).thenAnswer { localSones[it[0]] }
+               whenever(core.getPost(anyString())).thenAnswer { (posts + newPosts)[it[0]].asOptional() }
        }
 
        @Before
@@ -143,6 +152,14 @@ open class JsonPageTest(pageSupplier: (WebInterface) -> JsonPage = { _ -> mock<J
                remoteSones += sone.id to sone
        }
 
+       protected fun addLocalSone(id: String, sone: Sone) {
+               localSones += id to sone
+       }
+
+       protected fun addPost(id: String, post: Post) {
+               posts[id] = post
+       }
+
        protected fun addNewPost(id: String, soneId: String, time: Long, recipientId: String? = null) =
                        mock<Post>().apply {
                                whenever(this.id).thenReturn(id)
@@ -170,4 +187,19 @@ open class JsonPageTest(pageSupplier: (WebInterface) -> JsonPage = { _ -> mock<J
                linkedElements[link] = LinkedElement(link, failed, loading)
        }
 
+       @Test
+       fun `page returns correct path`() {
+               assertThat(page.path, equalTo(expectedPath))
+       }
+
+       @Test
+       fun `page needs form password`() {
+               assertThat(page.needsFormPassword(), equalTo(needsFormPassword))
+       }
+
+       @Test
+       fun `page requires login`() {
+               assertThat(page.requiresLogin(), equalTo(requiresLogin))
+       }
+
 }