🎨 Reduce mocking of albums and images

[Sone.git] / src / test / kotlin / net / pterodactylus / sone / web / pages / DeleteImagePageTest.kt

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/DeleteImagePageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/DeleteImagePageTest.kt
index 89e2879..eccf949 100644 (file)
--- a/src/test/kotlin/net/pterodactylus/sone/web/pages/DeleteImagePageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/DeleteImagePageTest.kt
@@ -1,38 +1,27 @@
 package net.pterodactylus.sone.web.pages
 
-import net.pterodactylus.sone.data.Album
-import net.pterodactylus.sone.data.Image
-import net.pterodactylus.sone.data.Sone
-import net.pterodactylus.sone.test.mock
-import net.pterodactylus.sone.test.whenever
-import net.pterodactylus.sone.web.pages.WebPageTest
-import net.pterodactylus.sone.web.pages.DeleteImagePage
-import net.pterodactylus.util.web.Method.GET
-import net.pterodactylus.util.web.Method.POST
-import org.hamcrest.MatcherAssert.assertThat
-import org.hamcrest.Matchers.equalTo
-import org.junit.Before
-import org.junit.Test
-import org.mockito.Mockito.verify
+import net.pterodactylus.sone.data.*
+import net.pterodactylus.sone.data.impl.*
+import net.pterodactylus.sone.test.*
+import net.pterodactylus.sone.web.*
+import net.pterodactylus.sone.web.page.*
+import net.pterodactylus.util.web.Method.*
+import org.hamcrest.MatcherAssert.*
+import org.hamcrest.Matchers.*
+import org.junit.*
+import org.mockito.Mockito.*
 
 /**
  * Unit test for [DeleteImagePage].
  */
-class DeleteImagePageTest: WebPageTest() {
+class DeleteImagePageTest : WebPageTest(::DeleteImagePage) {
 
-       private val page = DeleteImagePage(template, webInterface)
-       private val image = mock<Image>()
        private val sone = mock<Sone>()
-
-       override fun getPage() = page
+       private val image = ImageImpl("image-id").modify().setSone(sone).update()!!
 
        @Before
        fun setupImage() {
-               val album = mock<Album>()
-               whenever(album.id).thenReturn("album-id")
-               whenever(image.id).thenReturn("image-id")
-               whenever(image.sone).thenReturn(sone)
-               whenever(image.album).thenReturn(album)
+               AlbumImpl(sone, "album-id").also { it.addImage(image) }
                whenever(sone.isLocal).thenReturn(true)
        }
 
@@ -48,13 +37,11 @@ class DeleteImagePageTest: WebPageTest() {
 
        @Test
        fun `get request with invalid image redirects to invalid page`() {
-               request("", GET)
                verifyRedirect("invalid.html")
        }
 
        @Test
        fun `get request with image from non-local sone redirects to no permissions page`() {
-               request("", GET)
                whenever(sone.isLocal).thenReturn(false)
                addImage("image-id", image)
                addHttpRequestParameter("image", "image-id")
@@ -63,7 +50,6 @@ class DeleteImagePageTest: WebPageTest() {
 
        @Test
        fun `get request with image from local sone sets image in template context`() {
-               request("", GET)
                addImage("image-id", image)
                addHttpRequestParameter("image", "image-id")
                page.processTemplate(freenetRequest, templateContext)
@@ -72,7 +58,7 @@ class DeleteImagePageTest: WebPageTest() {
 
        @Test
        fun `post request with abort delete flag set redirects to image browser`() {
-               request("", POST)
+               setMethod(POST)
                addImage("image-id", image)
                addHttpRequestPart("image", "image-id")
                addHttpRequestPart("abortDelete", "true")
@@ -81,7 +67,7 @@ class DeleteImagePageTest: WebPageTest() {
 
        @Test
        fun `post request deletes image and redirects to image browser`() {
-               request("", POST)
+               setMethod(POST)
                addImage("image-id", image)
                addHttpRequestPart("image", "image-id")
                verifyRedirect("imageBrowser.html?album=album-id") {
@@ -89,4 +75,14 @@ class DeleteImagePageTest: WebPageTest() {
                }
        }
 
+       @Test
+       fun `page can be created by dependency injection`() {
+               assertThat(baseInjector.getInstance<DeleteImagePage>(), notNullValue())
+       }
+
+       @Test
+       fun `page is annotated with correct template path`() {
+               assertThat(page.templatePath, equalTo("/templates/deleteImage.html"))
+       }
+
 }