💄 Generalize rendering of histograms

[Sone.git] / src / test / kotlin / net / pterodactylus / sone / web / pages / MetricsPageTest.kt

diff --git a/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt b/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt
index ca69e66..5a5d588 100644 (file)
--- a/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt
+++ b/src/test/kotlin/net/pterodactylus/sone/web/pages/MetricsPageTest.kt
@@ -25,11 +25,10 @@ import org.hamcrest.MatcherAssert.*
 import org.hamcrest.Matchers.*
 import kotlin.test.*
 
-class MetricsPageTest : WebPageTest({ webInterface, loaders, templateRenderer -> MetricsPage(webInterface, loaders, templateRenderer, metricRegistry) }) {
+class MetricsPageTest : WebPageTest() {
 
-       companion object {
-               val metricRegistry = MetricRegistry()
-       }
+       private val metricRegistry = MetricRegistry()
+       override val page by lazy { MetricsPage(webInterface, loaders, templateRenderer, metricRegistry) }
 
        @Test
        fun `page returns correct path`() {
@@ -63,14 +62,38 @@ class MetricsPageTest : WebPageTest({ webInterface, loaders, templateRenderer ->
        }
 
        @Test
-       fun `metrics page lists stats about sone parsing durations`() {
-               createHistogram("sone.parsing.duration")
+       fun `metrics page auto-converts histogram name`() {
+               createHistogram("sone.random.duration")
+               page.handleRequest(soneRequest, templateContext)
+               verifyHistogram("soneRandomDuration")
+       }
+
+       @Test
+       @Suppress("UNCHECKED_CAST")
+       fun `metrics page stores histogram keys in template`() {
+               createHistogram("sone.random.duration2")
+               createHistogram("sone.random.duration1")
+               page.handleRequest(soneRequest, templateContext)
+               assertThat(templateContext["histogramKeys"] as Iterable<String>, contains("soneRandomDuration1", "soneRandomDuration2"))
+       }
+
+       @Test
+       fun `metrics page stores i18n names for histogram keys`() {
+               createHistogram("sone.random.duration1")
+               page.handleRequest(soneRequest, templateContext)
+               assertThat(templateContext["soneRandomDuration1I18n"] as String, equalTo("SoneRandomDuration1"))
+       }
+
+       @Test
+       fun `metrics page delivers correct histogram size`() {
+               val histogram = metricRegistry.histogram("sone.parsing.duration")
+               (0..4000).forEach(histogram::update)
                page.handleRequest(soneRequest, templateContext)
-               verifyHistogram("soneParsingDuration")
+               assertThat(templateContext["soneParsingDurationCount"] as Long, equalTo(4001L))
        }
 
        private fun verifyHistogram(name: String) {
-               assertThat(templateContext["${name}Count"] as Int, equalTo(5))
+               assertThat(templateContext["${name}Count"] as Long, equalTo(5L))
                assertThat(templateContext["${name}Min"] as Long, equalTo(1L))
                assertThat(templateContext["${name}Max"] as Long, equalTo(10L))
                assertThat(templateContext["${name}Median"] as Double, equalTo(8.0))