Remove some unnecessary qualifiers, whitespace, and comments
authorDavid ‘Bombe’ Roden <bombe@pterodactylus.net>
Fri, 31 Jul 2015 14:50:05 +0000 (16:50 +0200)
committerDavid ‘Bombe’ Roden <bombe@pterodactylus.net>
Fri, 31 Jul 2015 14:50:05 +0000 (16:50 +0200)
src/main/java/net/pterodactylus/sone/data/Reply.java

index 69769eb..cf50a5c 100644 (file)
@@ -20,6 +20,7 @@ package net.pterodactylus.sone.data;
 import java.util.Comparator;
 
 import com.google.common.base.Predicate;
+import com.google.common.primitives.Longs;
 
 /**
  * Defines methods common for all replies.
@@ -31,29 +32,19 @@ import com.google.common.base.Predicate;
 public interface Reply<T extends Reply<T>> extends Identified {
 
        /** Comparator that sorts replies ascending by time. */
-       public static final Comparator<? super Reply<?>> TIME_COMPARATOR = new Comparator<Reply<?>>() {
-
-               /**
-                * {@inheritDoc}
-                */
+       Comparator<? super Reply<?>> TIME_COMPARATOR = new Comparator<Reply<?>>() {
                @Override
                public int compare(Reply<?> leftReply, Reply<?> rightReply) {
-                       return (int) Math.max(Integer.MIN_VALUE, Math.min(Integer.MAX_VALUE, leftReply.getTime() - rightReply.getTime()));
+                       return Longs.compare(leftReply.getTime(), rightReply.getTime());
                }
-
        };
 
        /** Filter for replies with timestamps from the future. */
-       public static final Predicate<Reply<?>> FUTURE_REPLY_FILTER = new Predicate<Reply<?>>() {
-
-               /**
-                * {@inheritDoc}
-                */
+       Predicate<Reply<?>> FUTURE_REPLY_FILTER = new Predicate<Reply<?>>() {
                @Override
                public boolean apply(Reply<?> reply) {
                        return (reply != null) && (reply.getTime() <= System.currentTimeMillis());
                }
-
        };
 
        /**
@@ -61,7 +52,7 @@ public interface Reply<T extends Reply<T>> extends Identified {
         *
         * @return The ID of the reply
         */
-       public String getId();
+       String getId();
        String getInternalId();
 
        /**
@@ -69,36 +60,36 @@ public interface Reply<T extends Reply<T>> extends Identified {
         *
         * @return The Sone that posted this reply
         */
-       public Sone getSone();
+       Sone getSone();
 
        /**
         * Returns the time of the reply.
         *
         * @return The time of the reply (in milliseconds since Jan 1, 1970 UTC)
         */
-       public long getTime();
+       long getTime();
 
        /**
         * Returns the text of the reply.
         *
         * @return The text of the reply
         */
-       public String getText();
+       String getText();
 
        /**
         * Returns whether this reply is known.
         *
         * @return {@code true} if this reply is known, {@code false} otherwise
         */
-       public boolean isKnown();
+       boolean isKnown();
 
        /**
         * Sets whether this reply is known.
         *
         * @param known
-        *            {@code true} if this reply is known, {@code false} otherwise
+        *              {@code true} if this reply is known, {@code false} otherwise
         * @return This reply
         */
-       public T setKnown(boolean known);
+       T setKnown(boolean known);
 
 }