projects
/
Sone.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
eec3fc3
)
Don’t return Sone from removeLiked{Post,Reply}Id()
author
David ‘Bombe’ Roden
<bombe@pterodactylus.net>
Mon, 2 Oct 2017 13:47:13 +0000
(15:47 +0200)
committer
David ‘Bombe’ Roden
<bombe@pterodactylus.net>
Mon, 2 Oct 2017 13:47:13 +0000
(15:47 +0200)
src/main/java/net/pterodactylus/sone/data/Sone.java
patch
|
blob
|
history
src/main/java/net/pterodactylus/sone/data/impl/IdOnlySone.java
patch
|
blob
|
history
src/main/java/net/pterodactylus/sone/data/impl/SoneImpl.java
patch
|
blob
|
history
diff --git
a/src/main/java/net/pterodactylus/sone/data/Sone.java
b/src/main/java/net/pterodactylus/sone/data/Sone.java
index
258fb4c
..
b761c7b
100644
(file)
--- a/
src/main/java/net/pterodactylus/sone/data/Sone.java
+++ b/
src/main/java/net/pterodactylus/sone/data/Sone.java
@@
-443,10
+443,8
@@
public interface Sone extends Identified, Fingerprintable, Comparable<Sone> {
*
* @param postId
* The ID of the post
*
* @param postId
* The ID of the post
- * @return This Sone (for method chaining)
*/
*/
- @Nonnull
- Sone removeLikedPostId(@Nonnull String postId);
+ void removeLikedPostId(@Nonnull String postId);
/**
* Returns the IDs of all liked replies.
/**
* Returns the IDs of all liked replies.
@@
-491,10
+489,8
@@
public interface Sone extends Identified, Fingerprintable, Comparable<Sone> {
*
* @param replyId
* The ID of the reply
*
* @param replyId
* The ID of the reply
- * @return This Sone (for method chaining)
*/
*/
- @Nonnull
- Sone removeLikedReplyId(@Nonnull String replyId);
+ void removeLikedReplyId(@Nonnull String replyId);
/**
* Returns the root album that contains all visible albums of this Sone.
/**
* Returns the root album that contains all visible albums of this Sone.
diff --git
a/src/main/java/net/pterodactylus/sone/data/impl/IdOnlySone.java
b/src/main/java/net/pterodactylus/sone/data/impl/IdOnlySone.java
index
e9a0c57
..
79766b5
100644
(file)
--- a/
src/main/java/net/pterodactylus/sone/data/impl/IdOnlySone.java
+++ b/
src/main/java/net/pterodactylus/sone/data/impl/IdOnlySone.java
@@
-184,8
+184,7
@@
public class IdOnlySone implements Sone {
}
@Override
}
@Override
- public Sone removeLikedPostId(String postId) {
- return this;
+ public void removeLikedPostId(String postId) {
}
@Override
}
@Override
@@
-209,8
+208,7
@@
public class IdOnlySone implements Sone {
}
@Override
}
@Override
- public Sone removeLikedReplyId(String replyId) {
- return this;
+ public void removeLikedReplyId(String replyId) {
}
@Override
}
@Override
diff --git
a/src/main/java/net/pterodactylus/sone/data/impl/SoneImpl.java
b/src/main/java/net/pterodactylus/sone/data/impl/SoneImpl.java
index
439f4c9
..
0494607
100644
(file)
--- a/
src/main/java/net/pterodactylus/sone/data/impl/SoneImpl.java
+++ b/
src/main/java/net/pterodactylus/sone/data/impl/SoneImpl.java
@@
-533,12
+533,9
@@
public class SoneImpl implements Sone {
*
* @param postId
* The ID of the post
*
* @param postId
* The ID of the post
- * @return This Sone (for method chaining)
*/
*/
- @Nonnull
- public Sone removeLikedPostId(@Nonnull String postId) {
+ public void removeLikedPostId(@Nonnull String postId) {
likedPostIds.remove(postId);
likedPostIds.remove(postId);
- return this;
}
/**
}
/**
@@
-595,12
+592,9
@@
public class SoneImpl implements Sone {
*
* @param replyId
* The ID of the reply
*
* @param replyId
* The ID of the reply
- * @return This Sone (for method chaining)
*/
*/
- @Nonnull
- public Sone removeLikedReplyId(@Nonnull String replyId) {
+ public void removeLikedReplyId(@Nonnull String replyId) {
likedReplyIds.remove(replyId);
likedReplyIds.remove(replyId);
- return this;
}
/**
}
/**