Don’t trigger if state was not successful.

[rhynodge.git] / src / main / java / net / pterodactylus / reactor / engine / Engine.java

diff --git a/src/main/java/net/pterodactylus/reactor/engine/Engine.java b/src/main/java/net/pterodactylus/reactor/engine/Engine.java
index a8c9f4e..4ba7887 100644 (file)
--- a/src/main/java/net/pterodactylus/reactor/engine/Engine.java
+++ b/src/main/java/net/pterodactylus/reactor/engine/Engine.java
@@ -27,6 +27,7 @@ import net.pterodactylus.reactor.Query;
 import net.pterodactylus.reactor.Reaction;
 import net.pterodactylus.reactor.Trigger;
 import net.pterodactylus.reactor.states.AbstractState;
+import net.pterodactylus.reactor.states.FailedState;
 
 import org.apache.log4j.Logger;
 
@@ -122,6 +123,9 @@ public class Engine extends AbstractExecutionThreadService {
                        try {
                                logger.debug("Querying system...");
                                state = query.state();
+                               if (state == null) {
+                                       state = FailedState.INSTANCE;
+                               }
                                logger.debug("System queried.");
                        } catch (Throwable t1) {
                                logger.warn("Querying system failed!", t1);
@@ -133,16 +137,20 @@ public class Engine extends AbstractExecutionThreadService {
 
                        /* convert states. */
                        for (Filter filter : nextReaction.filters()) {
-                               net.pterodactylus.reactor.State newState = filter.filter(state);
-                               logger.debug(String.format("Old state is %s, new state is %s.", state, newState));
-                               state = newState;
+                               if (state.success()) {
+                                       net.pterodactylus.reactor.State newState = filter.filter(state);
+                                       logger.debug(String.format("Old state is %s, new state is %s.", state, newState));
+                                       state = newState;
+                               }
+                       }
+                       if (state.success()) {
+                               reactionExecution.addState(state);
                        }
-                       reactionExecution.addState(state);
 
                        /* only run trigger if we have collected two states. */
                        Trigger trigger = nextReaction.trigger();
                        boolean triggerHit = false;
-                       if (reactionExecution.previousState() != null) {
+                       if ((reactionExecution.previousState() != null) && state.success()) {
                                logger.debug("Checking Trigger for changes...");
                                triggerHit = trigger.triggers(reactionExecution.currentState(), reactionExecution.previousState());
                        }